fix: the VIP overlay waits for etcd's cluster, as etcd does (keel#106) #189

Merged

navigator merged 3 commits from fix/vip-overlay-waits-for-etcd-106 into main 2026-10-16 10:54:42 -03:00

Conversation 0 Commits 3 Files changed 7 +190 -4

navigator commented 2026-10-16 07:12:21 -03:00

Owner

Copy link

Fixes #106. Stacked on #187 (common#56), which is stacked on #185: merge those first.

keel-vip.service has ConditionPathExists=/var/lib/keel/etcd/cluster.json, so it never runs in cloud simple, and in cloud advanced it waits until etcd forms. Before, keel diff reported overlays.vip: drift (declared enabled, observed keel-vip.service enabled and inactive) on every cloud simple pair, and each apply printed "start keel-vip.service: done" for a start that did nothing.

What changes, mirroring what etcd's overlay does while it waits for its cluster:

• keel diff: before cluster.json exists, overlays.vip compares only whether the unit is enabled, and gives the reason (without etcd, keel vip check and its timer do the VIP's work). A unit that is not enabled is still drift.
• keel spec apply: before cluster.json exists, the unit is enabled and not started, and the step says why. With the cluster, both compare and converge the unit as before.

Tests: tests/test_vip_overlay_waits.py (diff and apply, before and after the cluster). The cross-site test of 19.0-3 runs in cloud advanced, so CI is the proof of the cloud simple case.

keel 0.23.35.

Fixes #106. Stacked on #187 (common#56), which is stacked on #185: merge those first. `keel-vip.service` has `ConditionPathExists=/var/lib/keel/etcd/cluster.json`, so it never runs in cloud simple, and in cloud advanced it waits until etcd forms. Before, `keel diff` reported `overlays.vip: drift (declared enabled, observed keel-vip.service enabled and inactive)` on every cloud simple pair, and each apply printed "start keel-vip.service: done" for a start that did nothing. What changes, mirroring what etcd's overlay does while it waits for its cluster: - `keel diff`: before `cluster.json` exists, `overlays.vip` compares only whether the unit is enabled, and gives the reason (without etcd, `keel vip check` and its timer do the VIP's work). A unit that is not enabled is still drift. - `keel spec apply`: before `cluster.json` exists, the unit is enabled and not started, and the step says why. With the cluster, both compare and converge the unit as before. Tests: `tests/test_vip_overlay_waits.py` (diff and apply, before and after the cluster). The cross-site test of 19.0-3 runs in cloud advanced, so CI is the proof of the cloud simple case. keel 0.23.35.

navigator added 9 commits 2026-10-16 07:12:21 -03:00

test: a reseed works when repl has no CONNECT on a database (keel#183) ... ecad9eaa5a

The reseed probe sums pg_database_size() over every database as the
role repl. That function needs CONNECT on the database. The keel-lnpp
check database revoked CONNECT from PUBLIC, and every reseed of the
LNPP pair refused: "permission denied for database keel_check".

The netns test of the pair now revokes CONNECT on the shop database
from PUBLIC before case (d), as the check database did. The unit tests
ask that the probe measures only the databases repl may connect to,
and that a refusal for lack of space names the databases it left out.

fix: the reseed probe measures only the databases repl may connect to (keel#183) ... e33d7f3a5b

pg_database_size() needs CONNECT on the database or the role
pg_read_all_stats. An application database with REVOKE CONNECT FROM
PUBLIC stopped every reseed with "permission denied".

The probe now sums the size with a FILTER on
has_database_privilege(oid, 'CONNECT') and counts the databases it
leaves out. The free space check uses the size it has. When the check
refuses, the message says how many databases the need leaves out. The
base backup itself is not changed: it copies the whole cluster.

pg_read_all_stats is not granted to repl: it gives more read access
than the reseed needs.

chore: keel 0.23.33 (keel#183) a6271bbc9b

test: the other member of a pair gets the primary's Anubis key (common#56) ... fa7c2f14a9

On a pair, keel-overlay-anubis-key.service makes no key on the database
replica: the key is shared and comes from the primary (decision 0041).
Nothing copied it, so anubis@keel did not start there, and the apply
failed the anubis overlay. The LNMP and LNPP pair tests copied the key
by hand (Keel-Linux/common#56).

The tests ask that the other member of the pair record, and no other
member, gets the key over the members' channel; that a paired replica
with no key asks for it in a run that may change the machine, and
writes it with mode 0600 before Anubis starts; that a replica in no
pair yet starts nothing and says why; and that an unreachable primary
refuses the step.

fix: a paired replica asks the other member for Anubis's key (common#56) ... c8ccb7fa98

The secret message of the members' channel gives a second name,
anubis/signing_key, answered with /etc/anubis/keel.key only to the
other member of the pair record, as the replication credential is.

keel.system.anubiskey observes, on the live system and only in a run
that may change the machine, a node whose spec makes it a database
replica, with Anubis enabled, no key file and no
secrets.anubis_signing_key declared. It asks the other member of its
pair, and the plan writes the key (mode 0600) before the overlay's
units start. The key unit then finds the key and leaves it.

Before the pair record exists, the apply starts nothing for Anubis and
says why, so the first boot of a replica no longer fails the overlay. A
key that is there is never replaced.

chore: keel 0.23.34 (common#56) 240512d44c

test: the VIP overlay waits for etcd's cluster with no drift (keel#106) ... 6b44929057

keel-vip.service starts only when /var/lib/keel/etcd/cluster.json
exists. On a cloud simple pair, keel diff reported overlays.vip as
drift (enabled and inactive) on every run, and each apply printed a
start of the unit that did nothing.

The tests ask that, before the cluster exists, diff compares only
whether the unit is enabled and says why it does not run, and that
apply enables the unit and does not start it. With the cluster, an
inactive controller is drift and apply starts it, as before.

fix: the VIP overlay waits for etcd's cluster, as etcd does (keel#106) ... f53f31fe45

Before etcd's cluster.json exists (always in cloud simple, and in
cloud advanced until etcd forms), the start condition of
keel-vip.service holds it. keel diff now compares only whether the
unit is enabled, and gives the reason: without etcd, keel vip check
(keel-vip-check.timer) does the VIP's work. keel spec apply enables the
unit, does not start it, and says why. With the cluster, both compare
and converge the unit as before.

chore: keel 0.23.35 (keel#106) b1f0252597

navigator referenced this pull request 2026-10-16 07:12:49 -03:00

fix: the fence of an old MariaDB primary ends its connections (keel#186, keel#193) #190

navigator force-pushed fix/vip-overlay-waits-for-etcd-106 from b1f0252597 to 093da566b6 2026-10-16 07:16:21 -03:00 Compare

navigator referenced this pull request 2026-10-16 07:24:18 -03:00

fix: an apply that starts etcd records it, and the start enables wireguard (keel#188) #191

navigator referenced this pull request 2026-10-16 07:51:36 -03:00

fix: the VIP fence of a caught-up MariaDB replica is cleared (keel#192) #194

navigator force-pushed fix/vip-overlay-waits-for-etcd-106 from 093da566b6 to a4790d991a 2026-10-16 07:54:59 -03:00 Compare

navigator referenced this pull request 2026-10-16 08:23:14 -03:00

database: a cut MariaDB holder acknowledges a write when the dump thread ends, before the fence (no VIP state at the release, wait_no_slave OFF) #195

navigator force-pushed fix/vip-overlay-waits-for-etcd-106 from a4790d991a to 7df4bc9649 2026-10-16 10:04:19 -03:00 Compare

navigator referenced this pull request 2026-10-16 10:04:38 -03:00

fix: a MariaDB holder whose lease is in doubt acknowledges no write (keel#195) #197

navigator merged commit 61d4060f4b into main 2026-10-16 10:54:42 -03:00

navigator referenced this pull request from a commit 2026-10-16 10:54:42 -03:00

Merge pull request 'fix: the VIP overlay waits for etcd's cluster, as etcd does (keel#106)' (#189) from fix/vip-overlay-waits-for-etcd-106 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

accessibility

Barrier affecting people with disabilities

  

bug

Something isn't working

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

accessibility

bug

documentation

duplicate

enhancement

good first issue

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Keel-Linux/keel!189

No description provided.