keel spec set: one writer for instance.yaml #69

New issue

Open

opened 2026-10-02 19:10:48 -03:00 by marcos-mendez · 0 comments

marcos-mendez commented

2026-10-02 19:10:48 -03:00

(Migrated from github.com)

confconsole (keelcli.py) and inithooks (libinithooks/fqdn.py, PR #36) each carry their own writer for /etc/keel/instance.yaml: PyYAML safe_dump, copy beside the file, keel spec validate --no-secret-files, os.replace. Comments are lost and the two can drift. keel should expose the writer once (keel spec set instance.fqdn=web.example.org, or a Python API) with the same validate-then-replace guarantee, preserving comments and file mode, and both callers should move to it. Found 2026-10-02 while making confconsole's Let's Encrypt screen read and write the spec (confconsole#22).

confconsole (keelcli.py) and inithooks (libinithooks/fqdn.py, PR #36) each carry their own writer for /etc/keel/instance.yaml: PyYAML safe_dump, copy beside the file, `keel spec validate --no-secret-files`, os.replace. Comments are lost and the two can drift. keel should expose the writer once (`keel spec set instance.fqdn=web.example.org`, or a Python API) with the same validate-then-replace guarantee, preserving comments and file mode, and both callers should move to it. Found 2026-10-02 while making confconsole's Let's Encrypt screen read and write the spec (confconsole#22).