Make this a Keel package with a version we choose #8
Labels
No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Keel-Linux/fab#8
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Decision by the maintainer, 2026-09-28: stop patching TurnKey's fab and make
this a Keel package with a version we choose.
#7is the symptom: the build host runsfab 1.1.1+keel2, a version thatexists in no commit of this repository, because two pull requests that changed
the order of the build's phases merged without a changelog entry and the
version was bumped at packaging time. A
+keelNsuffix on somebody else'sversion string says we patched their thing; it is a half measure, and
1.1.1+keel2is what that half measure produces.This follows the pattern already set by
keel-versionandkeel-sysinfo(Keel-Linux/tracker#13) and by the command naming policy (handbook decision
0015): where the project depends on something, it owns it.
What has to be true
upstream's, built into our archive and signed like everything else.
Provides,Replacesand
Conflictsagainstfab, so the build host converts cleanly and cannever end up carrying both.
fab-chroot,fab-apply-overlay,FAB_PATHand$(FAB_PATH)/commonappear throughoutbuildtasks, in every recipe Makefile and in the bootstrap. Renaming thebinaries is a larger change than renaming the package and must not be
bundled into this one. The call sites decide it, so inventory them first.
#7answered in the new shape: "which fabbuilt this layer" must be checkable from a manifest and a git tag, in both
directions. Owning the package makes that easier, not optional.
require-changelogworkflow. Ithas only
tests.ymltoday, which is the direct cause of#7.The constraint that dominates
fab builds every layer. A broken fab stops the project.
The package and the migration plan are the deliverable; installing it on the
build host is a separate, scheduled step with the old package kept installable
and a written way back. Nothing here may leave the build host unable to build,
and no rebuild or reinstall happens as part of this issue.
Recorded where
Handbook decision note 0017, its own issue and pull request in that
repository. 0014, 0015 and 0016 are taken by work in flight, so the number is
fixed rather than "the next free one".