The version may live in the source name, as TurnKey recipes write it #10

Merged

marcos-mendez merged 1 commit from fix/changelog-version-in-the-name into main

2026-09-27 20:33:34 -03:00

marcos-mendez commented

2026-09-27 20:31:17 -03:00

(Migrated from github.com)

A trailing version in the source name is now read as the upstream part and joined to the revision, giving 18.1-1 and 19.0-1, which dpkg orders correctly. A name with no version keeps the Debian reading.

A gate that refuses honest work teaches people to bypass it, which is worse than not having it.

Test plan

Three new cases: the version in the source name is read and compared, a revision that goes backwards is still refused under that convention, and a plain Debian name behaves exactly as before.
16 tests, bin/require-changelog 57 of 57 lines, total 100 percent.
The two pull requests it was refusing, keel-lamp#2 and keel-lapp#2, are the real cases.

The check read the parenthesised version alone. That is the whole version in a Debian package and only the appliance revision in a TurnKey recipe, where the distribution version sits in the source name. So `turnkey-lamp-18.1 (1)` and `turnkey-lamp-19.0 (1)` compared equal, and the check refused the LAMP and LAPP rebuilds although their entry was new and their version had moved a whole release. A trailing version in the source name is now read as the upstream part and joined to the revision, giving `18.1-1` and `19.0-1`, which dpkg orders correctly. A name with no version keeps the Debian reading. A gate that refuses honest work teaches people to bypass it, which is worse than not having it. ## Test plan - Three new cases: the version in the source name is read and compared, a revision that goes backwards is still refused under that convention, and a plain Debian name behaves exactly as before. - 16 tests, `bin/require-changelog` 57 of 57 lines, total 100 percent. - The two pull requests it was refusing, keel-lamp#2 and keel-lapp#2, are the real cases.