ci: security scanning, with the findings read and justified #4

Merged

marcos-mendez merged 1 commit from ci/security-scan into keel/trixie

2026-10-07 15:21:16 -03:00

marcos-mendez commented

2026-10-07 15:00:16 -03:00

(Migrated from github.com)

Calls security-scan.yml of keel-linux/.github (gitleaks, bandit,
semgrep, shellcheck on hosted runners, no secrets) on pull requests,
pushes to keel/trixie and by hand. Not a required check.

Baseline from a scan of keel/trixie, none a risk as packaged. semgrep
(19, upstream Go; vendor/ is not scanned): the two open-redirect hits
are upstream's PassChallenge, closed in the package by
debian/patches/redir-same-host.patch and redir-validate.patch, and
ServeHTTPNext's no-TARGET branch, which Keel never runs (a TARGET is
always set). Cookie HttpOnly and Secure come from operator options;
TLS configs keep Go's 1.2 minimum and verify certificates unless the
operator opts out; math/rand only for non-secret values; SHA-1 for a
Windows service SID; the private keys are config-test fixtures.
shellcheck (50): rc.d variables of run/anubis.freebsd and code
generation scripts of vendored Go modules, never run or installed.

gitleaks: upstream's test keys (lib/config/testdata/tls/, the gitweb
test's SSH key) are allowlisted by path in .github/gitleaks.toml; a
docs line naming the ED25519_PRIVATE_KEY_HEX variable is ignored by
fingerprint in .github/.gitleaksignore.

Calls security-scan.yml of keel-linux/.github (gitleaks, bandit, semgrep, shellcheck on hosted runners, no secrets) on pull requests, pushes to keel/trixie and by hand. Not a required check. Baseline from a scan of keel/trixie, none a risk as packaged. semgrep (19, upstream Go; vendor/ is not scanned): the two open-redirect hits are upstream's PassChallenge, closed in the package by debian/patches/redir-same-host.patch and redir-validate.patch, and ServeHTTPNext's no-TARGET branch, which Keel never runs (a TARGET is always set). Cookie HttpOnly and Secure come from operator options; TLS configs keep Go's 1.2 minimum and verify certificates unless the operator opts out; math/rand only for non-secret values; SHA-1 for a Windows service SID; the private keys are config-test fixtures. shellcheck (50): rc.d variables of run/anubis.freebsd and code generation scripts of vendored Go modules, never run or installed. gitleaks: upstream's test keys (lib/config/testdata/tls/, the gitweb test's SSH key) are allowlisted by path in .github/gitleaks.toml; a docs line naming the ED25519_PRIVATE_KEY_HEX variable is ignored by fingerprint in .github/.gitleaksignore.

github-advanced-security[bot] commented

2026-10-07 15:04:33 -03:00

(Migrated from github.com)

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. ### What Enabling Code Scanning Means: - The 'Security' tab will display more code scanning analysis results (e.g., for the default branch). - Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. - You will be able to see the analysis results for the pull request's branch on this [overview](/Keel-Linux/anubis/security/code-scanning?query=pr%3A4+is%3Aopen) once the scans have completed and the checks have passed. For more information about GitHub Code Scanning, check out [the documentation](https://docs.github.com/code-security/code-scanning/introduction-to-code-scanning/about-code-scanning).