fix: Database mode and network confirm screens say only what is true #18

Merged

marcos-mendez merged 2 commits from fix/console-screens-tell-the-truth into master

2026-10-02 07:15:47 -03:00

marcos-mendez commented

2026-10-02 06:15:04 -03:00

(Migrated from github.com)

Two confconsole screens from the maintainer's screenshots of the Core image (2026-10-02). confconsole 2.2.3+keel11 (master took keel9 and keel10; master is merged in).

045, Database mode > Cloud > Primary on a machine with no database server. Root cause: dbscreen.engine_of appended everything keel inspect printed on stderr to the no-server text. inspect had written its spec, so that stderr was about other fields: here "required fields not inferred: instance.fqdn". The screen now shows only the no-server text. (keel 0.15.1, Keel-Linux/keel#64, also stops requiring the fqdn.)
040, Overlay network confirm. Root cause: the verdict for exit 21 said "the change reverts when its window ends unless a new session confirms it", whatever keel's reason. keel also refuses when nothing is waiting, for example after another session confirmed it. The verdict is now "not confirmed: the reason is above", and keel's own line says which. With keel 0.15.1, a change already confirmed returns exit 0 and says so.

Tests written first: 643 pass, 5 skip; the measured modules stay at 100 percent lines and branches.

Real test: LXC container from the step 7b Core image with this package, keel 0.15.1, inithooks keel15 and keel-core 0.1.1; Primary showed only the no-server text, and the console confirm after an lxc-attach confirm showed "already confirmed ... it stays", exit 0. Container destroyed.

CI green
Review

Two confconsole screens from the maintainer's screenshots of the Core image (2026-10-02). confconsole 2.2.3+keel11 (master took keel9 and keel10; master is merged in). - **045, Database mode > Cloud > Primary on a machine with no database server.** Root cause: `dbscreen.engine_of` appended everything `keel inspect` printed on stderr to the no-server text. inspect had written its spec, so that stderr was about other fields: here "required fields not inferred: instance.fqdn". The screen now shows only the no-server text. (keel 0.15.1, Keel-Linux/keel#64, also stops requiring the fqdn.) - **040, Overlay network confirm.** Root cause: the verdict for exit 21 said "the change reverts when its window ends unless a new session confirms it", whatever keel's reason. keel also refuses when nothing is waiting, for example after another session confirmed it. The verdict is now "not confirmed: the reason is above", and keel's own line says which. With keel 0.15.1, a change already confirmed returns exit 0 and says so. Tests written first: 643 pass, 5 skip; the measured modules stay at 100 percent lines and branches. Real test: LXC container from the step 7b Core image with this package, keel 0.15.1, inithooks keel15 and keel-core 0.1.1; Primary showed only the no-server text, and the console confirm after an `lxc-attach` confirm showed "already confirmed ... it stays", exit 0. Container destroyed. - [ ] CI green - [ ] Review