ci: security scanning, with the findings read and justified #2

Merged

marcos-mendez merged 1 commit from ci/security-scan into keel/trixie

2026-10-07 15:21:29 -03:00

marcos-mendez commented

2026-10-07 14:53:56 -03:00

(Migrated from github.com)

Calls security-scan.yml of keel-linux/.github (gitleaks, bandit,
semgrep, shellcheck on hosted runners, no secrets) on pull requests,
pushes to keel/trixie and by hand. Not a required check.

A scan of keel/trixie finds nothing for bandit, and in upstream's
util/php-dictionary-gen, a maintainer tool the package does not
install: semgrep's ifs-tampering (IFS=$'\n\t' strict mode), three useless
cats and two shellcheck SC2046. Justified in .github/security-baseline.

gitleaks finds 7 tokens in upstream's regression tests, which are
attack payloads on purpose: the jwt.io sample JWT and made-up session
and OAuth tokens. .github/gitleaks.toml allowlists
tests/regression/tests/*.yaml by path.

Calls security-scan.yml of keel-linux/.github (gitleaks, bandit, semgrep, shellcheck on hosted runners, no secrets) on pull requests, pushes to keel/trixie and by hand. Not a required check. A scan of keel/trixie finds nothing for bandit, and in upstream's util/php-dictionary-gen, a maintainer tool the package does not install: semgrep's ifs-tampering (IFS=$'\n\t' strict mode), three useless cats and two shellcheck SC2046. Justified in .github/security-baseline. gitleaks finds 7 tokens in upstream's regression tests, which are attack payloads on purpose: the jwt.io sample JWT and made-up session and OAuth tokens. .github/gitleaks.toml allowlists tests/regression/tests/*.yaml by path.

github-advanced-security[bot] commented

2026-10-07 14:59:40 -03:00

(Migrated from github.com)

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. ### What Enabling Code Scanning Means: - The 'Security' tab will display more code scanning analysis results (e.g., for the default branch). - Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. - You will be able to see the analysis results for the pull request's branch on this [overview](/Keel-Linux/coreruleset/security/code-scanning?query=pr%3A2+is%3Aopen) once the scans have completed and the checks have passed. For more information about GitHub Code Scanning, check out [the documentation](https://docs.github.com/code-security/code-scanning/introduction-to-code-scanning/about-code-scanning).