Check the site before it is served #2
No reviewers
Labels
No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Keel-Linux/keel-linux.github.io!2
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/site-check"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The site had no gate. Nothing builds it, so a link that resolves to nothing,
an asset that was removed or an external link over plain HTTP went straight to
the public page with nobody in the way. It is the most visible repository in
the organization and the only active one with no required check.
tools/sitecheck.pydoes what a build step would have done: internal linksresolve, fragments name ids that exist (including on another page), every
referenced asset exists and every asset is referenced (counting the
og:imageand
twitter:imagecards a crawler fetches), external links are https ormailto, and each page has a language, a title and exactly one h1.
Two findings from the first run were real: the dark and one-colour marks were
served and referenced by nothing.
guidelines.htmlnow has a section for themark offering all four variants with the rules for using them.
Test plan
fails on a real broken link rather than only on a unit case.
tools/sitecheck.py99 percent lines and branches, against the 95 theproject asks of its own code.
python3 tools/sitecheck.py .exits 0 on this branch: 2 pages, 7 assets,0 findings.
python / coveragerequired onmain.