tkldev-setup: clone appliance APP from keel-APP on the keel-linux organization #3

Merged

marcos-mendez merged 2 commits from feat/keel-app-names into master

2026-09-26 06:39:49 -03:00

marcos-mendez commented

2026-09-26 06:36:18 -03:00

(Migrated from github.com)

Problem: tkldev-setup clones appliances as /, so with GIT_REMOTE_URL pointing at the organization tkldev-setup core asks for keel-linux/core, which does not exist: appliances are prefixed there (decision 0006), infrastructure is not.

Diagnosis: the only remote-dependent rule was the turnkeylinux one (append -apps for appliances); the organization needs a name mapping, not a different remote.

Fix: app_repo_name APP REMOTE maps APP to keel-APP when REMOTE has a keel-linux path component (https or ssh, any case) and APP is not already prefixed; the local directory stays $FAB_PATH/products/APP so make and bt-layer keep the appliance name. Every other remote behaves as before (turnkeylinux gets -apps, a mirror is used unchanged). Usage text updated.

Tests: 66 bats (3 new: the https organization remote with core becoming keel-core and common staying common; an ssh remote with wordpress and keel-lamp; app_repo_name on turnkeylinux-apps, an IPv6 mirror and an IPv6 organization mirror). tests/coverage.sh under kcov: tkldev-setup 99.48 percent (190 of 191 lines), above the 99 threshold of pull request #2.

Serves BRIEF section 10 and org-plan section 4 (naming rule of decision 0006).

Problem: tkldev-setup clones appliances as <remote>/<app>, so with GIT_REMOTE_URL pointing at the organization `tkldev-setup core` asks for keel-linux/core, which does not exist: appliances are prefixed there (decision 0006), infrastructure is not. Diagnosis: the only remote-dependent rule was the turnkeylinux one (append -apps for appliances); the organization needs a name mapping, not a different remote. Fix: app_repo_name APP REMOTE maps APP to keel-APP when REMOTE has a keel-linux path component (https or ssh, any case) and APP is not already prefixed; the local directory stays $FAB_PATH/products/APP so make and bt-layer keep the appliance name. Every other remote behaves as before (turnkeylinux gets -apps, a mirror is used unchanged). Usage text updated. Tests: 66 bats (3 new: the https organization remote with core becoming keel-core and common staying common; an ssh remote with wordpress and keel-lamp; app_repo_name on turnkeylinux-apps, an IPv6 mirror and an IPv6 organization mirror). tests/coverage.sh under kcov: tkldev-setup 99.48 percent (190 of 191 lines), above the 99 threshold of pull request #2. Serves BRIEF section 10 and org-plan section 4 (naming rule of decision 0006).