The MariaDB component, out of the shared tree and into a unit #1
No reviewers
Labels
No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Keel-Linux/unit-mariadb!1
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/the-mariadb-component"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The first component to move under decision 0010, now that
bt-layerrecords the units a layer carries andfabgives a unit its removelist andconf-varsslots.What came across, and from where:
plans/turnkey/mysqlplanoverlays/mysqloverlay/, byte identical, modes includedconf/mysqlconf, executable, three lines changedmk/turnkey/mysql.mkremovelists/mysqlThe conf script is the only file that differs, in three lines:
TKL_BASHLIB,BINandINITDbecame overridable defaults so the script can be run against scratch directories and measured. A build sets none of them, and the script ships nowhere, because fab copies it into the chroot, runs it and removes it with the temporary directory. Nothing the image gets is touched, which is the rule the extraction has to keep: the proof of this repository is a rebuiltmariadblayer compared against a build from the shared tree, and a file edited to be testable would appear in that comparison as a difference the extraction caused.MYSQL_PASSis deliberately not carried: fab now lets a unit name the build time variables its conf script reads, and this one reads none.Test plan:
bats tests/, 20 testsCOVERAGE_THRESHOLD=100 tests/coverage.sh, 100 percent (17/17), gate raised from the bootstrap 0mariadblayer from the shared tree, the same layer with this component as a unit, and the shared tree again, compared the way decision 0010 compares themMeasured: four builds of
bt-layer mariadb --parent coreon the build host, with the recipe change in keel-mariadb#11. Package list identical (438), symlinks identical (3,380), 179 of 35,315 files differing against a 179-file control-to-control noise floor, and nothing outside it. The three files and the one package line the first comparison showed extra are the recipe's changelog entry, which the fourth build measured on its own.