ci: security scanning, with the findings read and justified #4

Merged
marcos-mendez merged 1 commit from ci/security-scan into main 2026-10-07 17:32:38 -03:00
marcos-mendez commented 2026-10-07 14:54:16 -03:00 (Migrated from github.com)

Calls security-scan.yml of keel-linux/.github (gitleaks, bandit,
semgrep, shellcheck on hosted runners, no secrets) on pull requests,
pushes to main and by hand. Not a required check.

A scan of main finds no secret in the history, nothing for bandit or
semgrep, and five shellcheck warnings in
turnkey-mysql-install-perf-info-schemas, justified in
.github/security-baseline: "$@" in log messages, an unused variable,
and an always-true -n "DEBUG" that keeps the cleanup of the build
tree from running (a correctness defect, not a risk).

Calls security-scan.yml of keel-linux/.github (gitleaks, bandit, semgrep, shellcheck on hosted runners, no secrets) on pull requests, pushes to main and by hand. Not a required check. A scan of main finds no secret in the history, nothing for bandit or semgrep, and five shellcheck warnings in turnkey-mysql-install-perf-info-schemas, justified in .github/security-baseline: "$@" in log messages, an unused variable, and an always-true [[ -n "DEBUG" ]] that keeps the cleanup of the build tree from running (a correctness defect, not a risk).
github-advanced-security[bot] commented 2026-10-07 14:56:24 -03:00 (Migrated from github.com)

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. ### What Enabling Code Scanning Means: - The 'Security' tab will display more code scanning analysis results (e.g., for the default branch). - Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. - You will be able to see the analysis results for the pull request's branch on this [overview](/Keel-Linux/unit-mariadb/security/code-scanning?query=pr%3A4+is%3Aopen) once the scans have completed and the checks have passed. For more information about GitHub Code Scanning, check out [the documentation](https://docs.github.com/code-security/code-scanning/introduction-to-code-scanning/about-code-scanning).
Sign in to join this conversation.
No description provided.