fix: the ACL fragment comment keeps every line a comment #8

Merged
marcos-mendez merged 1 commit from fix/acl-fragment-comment into main 2026-10-08 00:14:04 -03:00
marcos-mendez commented 2026-10-07 22:43:12 -03:00 (Migrated from github.com)

lib/redis.sh:105: a line of the comment redis_acl_fragment writes into /etc/redis/redis.conf.d/50-keel-secret.conf had lost its #. Redis read it as a directive and redis-server refused to start ("Unresolved Configuration(s) Detected ... aborting"). Found by the headless boot of the Keel Redis 19.0-7 image, which is withdrawn.

  • The # is back.
  • tests/redis.bats: every line of the rendered fragment is a comment, blank or a user rule (fails on the old text, checked); a real redis-server on the shipped 20-keel-acl.conf plus the rendered fragment keeps running until a 3 s timeout (exit 124). The workflow installs redis-server so this runs in CI instead of skipping.
  • unit-redis 1.0.4 (changelog, version). Tag v1.0.4 after merge.
`lib/redis.sh:105`: a line of the comment `redis_acl_fragment` writes into `/etc/redis/redis.conf.d/50-keel-secret.conf` had lost its `#`. Redis read it as a directive and `redis-server` refused to start ("Unresolved Configuration(s) Detected ... aborting"). Found by the headless boot of the Keel Redis 19.0-7 image, which is withdrawn. - The `#` is back. - `tests/redis.bats`: every line of the rendered fragment is a comment, blank or a `user` rule (fails on the old text, checked); a real `redis-server` on the shipped `20-keel-acl.conf` plus the rendered fragment keeps running until a 3 s timeout (exit 124). The workflow installs `redis-server` so this runs in CI instead of skipping. - unit-redis 1.0.4 (changelog, version). Tag `v1.0.4` after merge.
Sign in to join this conversation.
No description provided.