rtl: scaffold InterChipFabric skeleton + chiseltest bench #82

Merged

navigator merged 2 commits from auto/issue-53-20260526T001906Z_issue53 into main 2026-05-26 13:37:01 -03:00

Conversation 5 Commits 2 Files changed 2 +133

navigator commented 2026-05-25 21:23:31 -03:00

Owner

Copy link

Implements the Chisel skeleton for InterChipFabric per
rtl/src/pop/specs/InterChipFabric.SPEC.md, satisfying the
PLAN.md §12.3 step-1/step-2 floor (module elaborates; chiseltest
harness exists).

Files

• rtl/src/pop/InterChipFabric.scala — module + IO bundle grouped
  on the four bullets of SPEC §Interface (N/S/E/W port quad per
  ADR-010, per-VC credit/return, PHY-facing PopLinkPHYIO attach per
  §13.3, routing/telemetry CSR window). All sub-bundles are empty
  placeholders tied to DontCare. Each TBD is annotated with the
  SPEC § it traces back to.
• rtl/tests/InterChipFabric/InterChipFabricSpec.scala — chiseltest
  AnyFlatSpec with the elaborate-only assertion.

Local validation

sbt compile and sbt 'testOnly pop.InterChipFabricSpec' both
green under the standalone rtl/ build (Scala 2.13.12 / Chisel
6.5.0 / chiseltest 6.0.0, pinned to Chipyard 1.13.0). The
elaborate test passes.

Out of scope

Per the issue: no behaviour, no golden model, no coverage. No SPEC
edits. No invented widths / port counts / VC count / CSR map for
spec TBD items — they remain DontCare with // TBD per SPEC §…
comments. Follow-ups will lift each facet once the SPEC promotes
out of stub and once the PopLinkPHY behavioral skeleton (issue #51)
publishes the canonical PopLinkPHYIO bundle type.

Closes #53

Implements the Chisel skeleton for `InterChipFabric` per `rtl/src/pop/specs/InterChipFabric.SPEC.md`, satisfying the PLAN.md §12.3 step-1/step-2 floor (module elaborates; chiseltest harness exists). ## Files * `rtl/src/pop/InterChipFabric.scala` — module + IO bundle grouped on the four bullets of SPEC §Interface (N/S/E/W port quad per ADR-010, per-VC credit/return, PHY-facing PopLinkPHYIO attach per §13.3, routing/telemetry CSR window). All sub-bundles are empty placeholders tied to `DontCare`. Each TBD is annotated with the SPEC § it traces back to. * `rtl/tests/InterChipFabric/InterChipFabricSpec.scala` — chiseltest `AnyFlatSpec` with the elaborate-only assertion. ## Local validation `sbt compile` and `sbt 'testOnly pop.InterChipFabricSpec'` both green under the standalone `rtl/` build (Scala 2.13.12 / Chisel 6.5.0 / chiseltest 6.0.0, pinned to Chipyard 1.13.0). The elaborate test passes. ## Out of scope Per the issue: no behaviour, no golden model, no coverage. No SPEC edits. No invented widths / port counts / VC count / CSR map for spec `TBD` items — they remain `DontCare` with `// TBD per SPEC §…` comments. Follow-ups will lift each facet once the SPEC promotes out of stub and once the PopLinkPHY behavioral skeleton (issue #51) publishes the canonical `PopLinkPHYIO` bundle type. Closes #53

navigator added 1 commit 2026-05-25 21:23:32 -03:00

rtl: scaffold InterChipFabric skeleton + chiseltest bench ... b6537cd3a2

Lands PLAN.md §12.3 step-1/step-2 floor for InterChipFabric:

* rtl/src/pop/InterChipFabric.scala — Chisel module + IO bundle
  grouped on the four bullets of SPEC §Interface (N/S/E/W port quad
  per ADR-010, per-VC credit/return, PHY-facing PopLinkPHYIO attach
  per §13.3, routing/telemetry CSR window). All sub-bundles are
  empty placeholders tied to DontCare; no widths, port counts, VC
  count or CSR map invented — every TBD is annotated with the
  SPEC § it traces back to.
* rtl/tests/InterChipFabric/InterChipFabricSpec.scala — chiseltest
  AnyFlatSpec with the elaborate-only assertion required as the
  §12.3 step-2 minimum.

Compiles green under the rtl/ standalone sbt (Scala 2.13.12 /
Chisel 6.5.0 / chiseltest 6.0.0, pinned to Chipyard 1.13.0) and the
elaborate test passes locally. Behaviour, golden model, ARQ stress
under injected BER, deadlock-freedom and the 8-chip torus stress
test are deliberately deferred — they land in follow-up issues once
SPEC §Interface and §Behavior lift from TBD.

SPEC file (rtl/src/pop/specs/InterChipFabric.SPEC.md) is unchanged
per the issue note that SPEC edits are a separate decision.

navigator added the

ready-for-review

label 2026-05-25 21:23:39 -03:00

navigator commented 2026-05-25 21:25:02 -03:00

Author

Owner

Copy link

VERDICT: FINDINGS

PR #82 adds the §12.3 step-1 scaffold for InterChipFabric — module + chiseltest harness — and is mechanically clean: SPDX headers correct (CHARRUA-1.2 for the RTL source, AGPL-3.0-or-later for the test), both files in package pop, IO bundle mirrors the four bullets of SPEC §Interface (ports, credits, phy, csr) as empty sub-bundles tied to DontCare, each TBD field annotated with the SPEC § it tracks, no widths/VC counts/flit layouts/CSR map invented, chiseltest bench has the prescribed it should "elaborate" floor, scope matches Issue #53, no AI attribution, no off-limits paths. The deferral of PopLinkPHYIO materialisation is justified honestly (canonical bundle awaits Issue #51 / behavioral PHY skeleton). One inline comment should be checked before merge: the VcCreditIO block attributes a quoted phrase — ADR-010 fixes "deadlock-free via XY routing + 2 VCs" — to ADR-010, but the SPEC's own ADR-010 reference is described only as "2D-torus topology" and the SPEC §Behavior carries VC allocation as TBD. The "2 VCs" is a specific number that may or may not be in ADR-010's actual text, and the same comment contradicts itself by saying "the bundle stays parametrised until §Behavior commits the VC count" — if ADR-010 already fixes 2 VCs, the bundle wouldn't need to wait on §Behavior. May be incorrect — please verify ADR-010 actually contains the "2 VCs" decision.

Findings

• "2 VCs" attribution to ADR-010 may be fabricated or self-contradictory — rtl/src/pop/InterChipFabric.scala (inline comment inside class VcCreditIO) — The comment puts a quoted string "deadlock-free via XY routing + 2 VCs" next to ADR-010 fixes, attributing the specific VC count of 2 to ADR-010. The SPEC's own Plan ref describes ADR-010 only as "2D-torus topology"; SPEC §Behavior carries VC allocation as TBD. The same comment then says the bundle "stays parametrised until §Behavior commits the VC count" — which contradicts the preceding clause that says ADR-010 already commits "2 VCs". Either ADR-010 contains the 2-VC fix (in which case the bundle is not still waiting on §Behavior for that number, and the comment should be tightened) or it doesn't (in which case the "2 VCs" is a fabricated specific number per rule 7). May be incorrect — please verify ADR-010's actual text. Suggested fix if ADR-010 doesn't cover VC count: // TBD per SPEC §Interface — per-VC credit / return interface (number of VCs, credit counter width, return-grouping policy). ADR-010 mandates dimension-ordered routing with VC partitioning for deadlock-freedom; the VC count itself is deferred to §Behavior. Bundle stays parametrised until §Behavior and §Invariants pin both the VC count and the credit-replenishment latency bound.

<!-- agent:review verdict=FINDINGS ts=1779755102 --> **VERDICT:** FINDINGS PR #82 adds the §12.3 step-1 scaffold for `InterChipFabric` — module + chiseltest harness — and is mechanically clean: SPDX headers correct (`CHARRUA-1.2` for the RTL source, `AGPL-3.0-or-later` for the test), both files in `package pop`, IO bundle mirrors the four bullets of SPEC §Interface (`ports`, `credits`, `phy`, `csr`) as empty sub-bundles tied to `DontCare`, each TBD field annotated with the SPEC § it tracks, no widths/VC counts/flit layouts/CSR map invented, chiseltest bench has the prescribed `it should "elaborate"` floor, scope matches Issue #53, no AI attribution, no off-limits paths. The deferral of `PopLinkPHYIO` materialisation is justified honestly (canonical bundle awaits Issue #51 / behavioral PHY skeleton). One inline comment should be checked before merge: the `VcCreditIO` block attributes a quoted phrase — `ADR-010 fixes "deadlock-free via XY routing + 2 VCs"` — to ADR-010, but the SPEC's own ADR-010 reference is described only as "2D-torus topology" and the SPEC §Behavior carries VC allocation as TBD. The "2 VCs" is a specific number that may or may not be in ADR-010's actual text, and the same comment contradicts itself by saying "the bundle stays parametrised until §Behavior commits the VC count" — if ADR-010 already fixes 2 VCs, the bundle wouldn't need to wait on §Behavior. May be incorrect — please verify ADR-010 actually contains the "2 VCs" decision. ## Findings - **"2 VCs" attribution to ADR-010 may be fabricated or self-contradictory** — `rtl/src/pop/InterChipFabric.scala` (inline comment inside `class VcCreditIO`) — The comment puts a quoted string `"deadlock-free via XY routing + 2 VCs"` next to `ADR-010 fixes`, attributing the specific VC count of 2 to ADR-010. The SPEC's own Plan ref describes ADR-010 only as "2D-torus topology"; SPEC §Behavior carries VC allocation as TBD. The same comment then says the bundle "stays parametrised until §Behavior commits the VC count" — which contradicts the preceding clause that says ADR-010 already commits "2 VCs". Either ADR-010 contains the 2-VC fix (in which case the bundle is *not* still waiting on §Behavior for that number, and the comment should be tightened) or it doesn't (in which case the "2 VCs" is a fabricated specific number per rule 7). May be incorrect — please verify ADR-010's actual text. Suggested fix if ADR-010 doesn't cover VC count: `// TBD per SPEC §Interface — per-VC credit / return interface (number of VCs, credit counter width, return-grouping policy). ADR-010 mandates dimension-ordered routing with VC partitioning for deadlock-freedom; the VC count itself is deferred to §Behavior. Bundle stays parametrised until §Behavior and §Invariants pin both the VC count and the credit-replenishment latency bound.`

navigator added the

review:findings

label 2026-05-25 21:25:03 -03:00

navigator referenced this pull request 2026-05-25 21:27:28 -03:00

rtl(FluidPopSoC): chisel skeleton + chiseltest elaborate-only spec #83

navigator commented 2026-05-25 23:31:38 -03:00

Author

Owner

Copy link

No description provided.

<!-- agent:pinged ts=1779762697 -->

navigator referenced this pull request 2026-05-26 01:10:10 -03:00

docs(spec): rewrite pop-soc-v1.md as Draft skeleton #89

navigator referenced this pull request 2026-05-26 01:19:52 -03:00

spec(InterChipFabric): promote InterChipFabric.SPEC.md to Draft #91

navigator added 1 commit 2026-05-26 13:31:28 -03:00

rtl(InterChipFabric): correct ADR-010 VC-credit comment — drop fabricated '2 VCs' quote ... abdb0755af

Reviewer flagged the VcCreditIO inline comment as putting a quoted
phrase 'deadlock-free via XY routing + 2 VCs' next to ADR-010, then
contradicting itself by saying the bundle stays parametrised until
§Behavior commits the VC count. ADR-010's actual scope is 2D-torus
topology — the VC count is not pinned there.

Rewrite the comment to match what the ADR actually mandates (2D-torus
with deadlock-free dimension-ordered routing) and clearly defer the
VC count itself to §Behavior, removing the fabricated quoted number.

navigator removed the

review:findings

label 2026-05-26 13:31:29 -03:00

navigator commented 2026-05-26 13:34:12 -03:00

Author

Owner

Copy link

VERDICT: PASS

PR #82 has been resubmitted at a new head SHA (abdb0755... vs the prior b6537cd3...) with my earlier finding addressed. The VcCreditIO inline comment in rtl/src/pop/InterChipFabric.scala has been rewritten from the self-contradictory version I flagged previously — which simultaneously claimed ADR-010 fixes "deadlock-free via XY routing + 2 VCs" and that the bundle stays parametrised pending §Behavior — to a clean conservative deferral: ADR-010 mandates 2D-torus topology with deadlock-free dimension-ordered routing; the VC count itself is not pinned by ADR-010 and stays parametrised until §Behavior commits a concrete number and §Invariants commits the credit-replenishment latency bound. This removes the self-contradiction and matches the exact fix-suggestion shape I proposed. The companion SPEC (InterChipFabric.SPEC.md) is now at Draft status (promoted by PR #91, which I PASSed and which retroactively confirmed that "2 VCs" does appear in both PLAN.md §3.5 and ADR-010 Consequences), so the current inline comment is in fact slightly under-attributing to ADR-010 — but that's a conservative direction that under-commits rather than over-commits, and it's no longer self-contradictory. Mechanical guardrails all pass: SPDX CHARRUA-1.2 for the RTL source and AGPL-3.0-or-later for the test, both in package pop, IO bundle mirrors the four bullets of SPEC §Interface (ports/credits/phy/csr) as empty DontCare-tied sub-bundles, each TBD annotated with the SPEC § it tracks, no widths/VC counts/flit layouts/CSR map invented, chiseltest bench has the prescribed it should "elaborate" floor, scope matches Issue #53 (two files added), no AI attribution, no off-limits paths, no Chisel module rules violated. The deferral of PopLinkPHYIO materialisation remains honestly tied to Issue #51's behavioral-PHY skeleton.

Findings

None.

<!-- agent:review verdict=PASS ts=1779813252 --> **VERDICT:** PASS PR #82 has been resubmitted at a new head SHA (`abdb0755...` vs the prior `b6537cd3...`) with my earlier finding addressed. The `VcCreditIO` inline comment in `rtl/src/pop/InterChipFabric.scala` has been rewritten from the self-contradictory version I flagged previously — which simultaneously claimed `ADR-010 fixes "deadlock-free via XY routing + 2 VCs"` and that the bundle stays parametrised pending `§Behavior` — to a clean conservative deferral: `ADR-010 mandates 2D-torus topology with deadlock-free dimension-ordered routing; the VC count itself is not pinned by ADR-010 and stays parametrised until §Behavior commits a concrete number and §Invariants commits the credit-replenishment latency bound`. This removes the self-contradiction and matches the exact fix-suggestion shape I proposed. The companion SPEC (`InterChipFabric.SPEC.md`) is now at Draft status (promoted by PR #91, which I PASSed and which retroactively confirmed that "2 VCs" does appear in both PLAN.md §3.5 and ADR-010 Consequences), so the current inline comment is in fact slightly under-attributing to ADR-010 — but that's a conservative direction that under-commits rather than over-commits, and it's no longer self-contradictory. Mechanical guardrails all pass: SPDX `CHARRUA-1.2` for the RTL source and `AGPL-3.0-or-later` for the test, both in `package pop`, IO bundle mirrors the four bullets of SPEC §Interface (`ports`/`credits`/`phy`/`csr`) as empty `DontCare`-tied sub-bundles, each TBD annotated with the SPEC § it tracks, no widths/VC counts/flit layouts/CSR map invented, chiseltest bench has the prescribed `it should "elaborate"` floor, scope matches Issue #53 (two files added), no AI attribution, no off-limits paths, no Chisel module rules violated. The deferral of `PopLinkPHYIO` materialisation remains honestly tied to Issue #51's behavioral-PHY skeleton. ## Findings _None._

navigator added the

review:pass

label 2026-05-26 13:34:12 -03:00

fluidpop-bot approved these changes 2026-05-26 13:34:50 -03:00

Dismissed

fluidpop-bot left a comment

Collaborator

Copy link

CI green (head abdb0755af), auto-approving

CI green (head abdb0755afc15f7341199c719f20afd24e35af1c), auto-approving

navigator force-pushed auto/issue-53-20260526T001906Z_issue53 from abdb0755af to 83403633fe 2026-05-26 13:34:53 -03:00 Compare

fluidpop-bot approved these changes 2026-05-26 13:37:00 -03:00

fluidpop-bot left a comment

Collaborator

Copy link

CI green (head 83403633fe), auto-approving

CI green (head 83403633fe291ae59fa452f3bb55023665e27c79), auto-approving

navigator merged commit f486a7638d into main 2026-05-26 13:37:01 -03:00

navigator referenced this pull request from a commit 2026-05-26 13:37:03 -03:00

rtl: scaffold InterChipFabric skeleton + chiseltest bench (#82)

Sign in to join this conversation.

Reviewers

No reviewers

fluidpop-bot

Labels

Clear labels   

adr

Architecture Decision Record

  

agent:blocked-ci

CI failed on the PR

  

agent:blocked-human

Operator escalated; awaiting Marcos input

  

agent:blocked-resolver

Resolver crashed, returned empty, or timed out

  

agent:done

PR merged; issue auto-closed

  

agent:in-progress

Resolver claimed and running

  

agent:no-touch

Human-reserved; swarm Opener/Dispatcher skip

  

agent:pinged

Operator already escalated; suppress repeat pings

  

agent:pr-open

Resolver opened a PR; awaiting review/merge

  

agent:queued

Issue ready for swarm Resolver to claim

  

agent:wip

PR work-in-progress; Approver skips

  

area:board

PCB / mechanical / cooling

  

area:funding

PACID / grants / RFQs

  

area:infra

Dev env, CI, containers

  

area:phy

Physical layer / SerDes

  

area:poplink

PopLink protocol

  

area:rtl

Chisel/RTL work

  

area:software

Driver / runtime / frameworks

  

area:supply-chain

Foundry, OSAT, PCB, components

  

area:verification

Test, formal, coverage

  

ci-failed

auto-merge.sh detected CI failure

  

ci-timeout

auto-merge.sh hit CI timeout

  

docs

Documentation

  

do-not-merge

Hard hold; PR Approver skips

  

human-approved

Marcos approved via Telegram; release governance hold

  

needs-human-approval

Touches governance path; awaits Marcos label human-approved

  

needs-rebase

PR is not mergeable; rebase needed

  

needs-triage

Issue from untrusted author; Marcos triage needed

  

phase:1

Phase 1 (Section 6 of PLAN.md)

  

ready-for-review

Resolver done; PR Approver triages

  

review:findings

PR semantic review flagged blocking findings

  

review:pass

PR semantic review passed; safe for pr-approver

  

risk:tripwire

Section 0.5 tripwire fired

  

swarm:quarantined

Escalation tripwire fired; resolver tried off-limits paths

No labels

adr

agent:blocked-ci

agent:blocked-human

agent:blocked-resolver

agent:done

agent:in-progress

agent:no-touch

agent:pinged

agent:pr-open

agent:queued

agent:wip

area:board

area:funding

area:infra

area:phy

area:poplink

area:rtl

area:software

area:supply-chain

area:verification

ci-failed

ci-timeout

docs

do-not-merge

human-approved

needs-human-approval

needs-rebase

needs-triage

phase:1

ready-for-review

review:findings

review:pass

risk:tripwire

swarm:quarantined

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Fluid/fluidpop-v1!82

No description provided.